Fix runtime search path for shared-lib and add '-static' to the name of static-lib. #5616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure about the change on #2639 and this StackOverflow mentions the problem of its lacking. The problems on |
|
Thanks! |
|
Sure. I will check the commands with each building settings and make the PR for |
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5578, this fix will solve the long-lasting linking problem of the OCaml binding of z3 shared lib.
The explanation is already here.
For short, the commit
libz3.sowill be installed later intoLIBZ3(a.k.a. the OCaml z3 lib). Later, eitherocamlcandocamloptcan find it without extra config.z3andz3-static, by the default name convention ofocamlmklib, both will bedllz3ml.so, which will result in the failure of the installation intoopam-site-lib/stublibs. I rename the static one todllz3ml-static.soby using-oc .... We don't need to change other files e.g.z3ml.cm*since they will be installed in its own pathopam-site-lib/{z3,z3-static}.To check the associated opam files, they are in my fix-ocaml-binging-with-opam branch, which is one extra commit ahead of this branch in PR.